Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore set library on loading #1251

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

pocke
Copy link
Member

@pocke pocke commented Feb 24, 2023

Fix #1250

Problem

set library has been moved from the standard library to the core library since Ruby 3.2. RBS also follows this change.
But there are many references to set library in manifest.yaml. So rbs collection command fails due to missing set library.

Solution

Ignore set library on loading the standard library.

It looks ad-hoc approach. But I think it is acceptable because moving to core is a rare case.

I also removed set library from rbs's manifest.yaml.

@soutaro soutaro added this to the RBS 3.0.x milestone Feb 27, 2023
@soutaro soutaro added this pull request to the merge queue Feb 27, 2023
Merged via the queue into ruby:master with commit 88f4f55 Feb 27, 2023
@pocke pocke deleted the Ignore__set__library_on_loading branch February 27, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find set from standard libraries
2 participants