Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An environment should reject duplicate type aliases, but actually, it just ignores the duplication due to a forgotten
raise
.This PR fixes the validation to raise an error on duplicate type aliases, like the following.
Additional Information
Interface has the same problem.
rbs/lib/rbs/environment.rb
Lines 364 to 371 in 0dd11d3
For example, the second
_I
conceals the first one in the following example.We can confirm this problem with the following command.
I think the interface should behave the same as the open class, instead of rejecting duplicated interfaces.I will create a PR to fix the interface problem soon.