Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should allow String and _ToStr for Object#define_singleton_method #1299

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Should allow String and _ToStr for Object#define_singleton_method #1299

merged 1 commit into from
Apr 14, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 6, 2023

define_singleton_method call C function rb_check_id for argument. It allows Symbol, String and _ToStr.

@ksss
Should allow String and _ToStr
ca629f8 
define_singleton_method call C function `rb_check_id` for argument.
It allows Symbol, String and _ToStr.
soutaro
soutaro approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this pull request to the merge queue Apr 14, 2023
@soutaro soutaro added this to the RBS 3.1 milestone Apr 14, 2023
@soutaro soutaro merged commit f0f21ca into ruby:master Apr 14, 2023
@ksss ksss deleted the object-name branch April 14, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro