Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bundle install automatically in bin/steep #1308

Merged

Conversation

pocke
Copy link
Member

@pocke pocke commented Apr 17, 2023

This PR adds bundle install into bin/steep to ensure install gems for Steep.

Problem

Currently, we need to run bundle install manually to run Steep. Because steep uses a different Gemfile.

But IDEs, such as VSCode, execute bin/steep transparently. Sometimes I overlooked the missing gems error because VSCode conceals the error (maybe VSCode displays the error as a small popup, but I never check the popup contents 😇).

Solution

Run bundle install in bin/steep. By this change, bin/steep doesn't fail by the missing gems error.

I've applied the same solution to our company project, and it works well.

@soutaro soutaro added this to the RBS 3.1 milestone Apr 25, 2023
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this pull request to the merge queue Apr 26, 2023
Merged via the queue into ruby:master with commit 488fec6 Apr 26, 2023
@pocke pocke deleted the Run__bundle_install__automatically_in_bin_steep branch April 26, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants