Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print detailed_message on parse command #1329

Merged
merged 3 commits into from
May 16, 2023
Merged

Print detailed_message on parse command #1329

merged 3 commits into from
May 16, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented May 13, 2023

Extends the error display when parsing fails with the parse command.
This improves the user experience by making it easier to identify which part was at fault.

before

after

soutaro
soutaro approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.2 milestone May 16, 2023
@soutaro soutaro added this pull request to the merge queue May 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2023
@soutaro soutaro added this pull request to the merge queue May 16, 2023
@soutaro soutaro merged commit ebb5257 into ruby:master May 16, 2023
@ksss ksss deleted the e-detailed_message branch May 17, 2023 02:28
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro