Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle connection error with Resolv_test.rb #1356

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Handle connection error with Resolv_test.rb #1356

merged 1 commit into from
Jul 3, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jun 16, 2023

see https://github.com/ruby/rbs/actions/runs/5285494174/jobs/9564033234#step:10:26

We sometimes faced "connection refused" issue in our CI containded ruby/ruby repo. I added rescue block with Errno::ECONNREFUSED for this.

pocke
pocke approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke added this pull request to the merge queue Jul 3, 2023
Merged via the queue into master with commit 3c7387e Jul 3, 2023
31 checks passed
@pocke pocke deleted the rescue-connection-refused branch July 3, 2023 02:28
@soutaro soutaro added this to the RBS 3.2 milestone Jul 18, 2023
soutaro pushed a commit that referenced this pull request Jul 18, 2023
@pocke @soutaro
Merge pull request #1356 from ruby/rescue-connection-refused
0abb5ba 
Handle connection error with Resolv_test.rb
@soutaro soutaro mentioned this pull request Jul 18, 2023
Merged
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hsbt @pocke @soutaro