Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify rbs syntax to code snippets in Markdown files #1366

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

ybiquitous
Copy link
Contributor

Linguist 7.26.0 has supported the RBS syntax, and RBS syntax highlighting is now available on github.com.

So, this change specifies the rbs syntax to code snippets in Markdown files.

Linguist 7.26.0 has supported the RBS syntax, and RBS syntax highlighting is now available on github.com.
So, this change specifies the `rbs` syntax to code snippets in Markdown files.

See also <https://github.com/github-linguist/linguist/releases/tag/v7.26.0>
@@ -6,20 +6,20 @@ The purpose of this doc is to teach you how to write RBS signatures by using the

## Examples

In each example, the first snippet is for *Ruby* and the second one is for *RBS*.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] I thought # .rb and # .rbs in snippets are redundant, so I've removed them and added the description above.

@ybiquitous ybiquitous marked this pull request as ready for review July 6, 2023 23:19
docs/stdlib.md Outdated Show resolved Hide resolved
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@soutaro soutaro enabled auto-merge July 7, 2023 05:15
@soutaro soutaro added this pull request to the merge queue Jul 7, 2023
Merged via the queue into ruby:master with commit 6302e0f Jul 7, 2023
31 checks passed
@ybiquitous ybiquitous deleted the use-rbs-syntax-in-markdown-files branch July 7, 2023 05:41
@soutaro soutaro added this to the RBS 3.2 milestone Jul 18, 2023
@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants