Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated builtin.rbs's interfaces #1429

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Updated builtin.rbs's interfaces #1429

merged 1 commit into from
Aug 18, 2023

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Aug 18, 2023 •
edited
Loading

Adds the missing _ToC, _ToH, and _ToSym interfaces. Additionally, moved over _ToA and _ToAry ones from array.rbs, and reorganized builtin.rbs slightly.

@sampersand sampersand force-pushed the swesterman/23-08-17/update-builtin-interfaces branch from b2b8d44 to 63d25f3 Compare August 18, 2023 03:14
@sampersand sampersand marked this pull request as ready for review August 18, 2023 03:15
soutaro
soutaro approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sampersand!
I'm good to merge this PR, but not very clear if we really need the to_c, to_r, ... interfaces yet.

@soutaro soutaro added this pull request to the merge queue Aug 18, 2023
@soutaro soutaro added this to the RBS 3.2 milestone Aug 18, 2023
Merged via the queue into ruby:master with commit 73a4d8c Aug 18, 2023
23 checks passed
@sampersand
Copy link
Contributor Author

The to_r interface was already present; It felt weird to have it without .to_c, so I added _ToC. I've used .to_sym a lot personally, and I was surprised it didn't exist.

@soutaro soutaro added the Released PRs already included in the released version label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sampersand @soutaro