Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rbs diff command #1459

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Implement rbs diff command #1459

merged 3 commits into from
Oct 30, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Aug 23, 2023

Design

#1448

Note

To ship the smallest increment, the option to display the defined position is not implemented.

Feature

  • instance methods
  • singleton methods
  • constants

Future Plans

  • Support mixin, ivar, cvar
  • Add option to print defined_in and visibility
  • load manifest.yaml

Demo

Show differences in ActiveStorage::Attachment class between v6.0 and v6.1 of activestorage.

$ bundle exec rbs --no-collection diff --format diff --type-name ActiveStorage::Attachment --before ../gem_rbs_collection/gems/activestorage/6.0 --after ../gem_rbs_collection/gems/activestorage/6.1
- def self.has_one_attached: (::String | ::Symbol name, ?dependent: ::Symbol dependent) -> void
+ def self.has_one_attached: (::String | ::Symbol name, ?dependent: ::Symbol dependent, ?service: ::String | ::Symbol | nil service, ?strict_loading: bool strict_loading) -> void

- def self.has_many_attached: (::String | ::Symbol name, ?dependent: ::Symbol dependent) -> void
+ def self.has_many_attached: (::String | ::Symbol name, ?dependent: ::Symbol dependent, ?service: ::String | ::Symbol | nil service, ?strict_loading: bool strict_loading) -> void

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Merged via the queue into ruby:master with commit 32cd6c9 Oct 30, 2023
23 checks passed
@ksss ksss deleted the diff branch October 30, 2023 07:10
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants