Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should keep escape of alias and attr family #1486

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Should keep escape of alias and attr family #1486

merged 1 commit into from
Sep 5, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 1, 2023

Passing RBS::Writer for the aliases and attr family will cause the backquote to be off and output an RBS that results in a syntax error.

I fixed RBS::Writer so that backquotes are kept.

soutaro
soutaro approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro added this pull request to the merge queue Sep 5, 2023
@soutaro soutaro added this to the RBS 3.3 milestone Sep 5, 2023
Merged via the queue into ruby:master with commit f8e43c3 Sep 5, 2023
23 checks passed
@ksss ksss deleted the writer-escape branch September 5, 2023 02:10
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro