[prototype runtime] Optimize performance #1495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the number of modules/classes is large and the path is deep, there is a problem that the performance of
rbs prototype runtime
is extremely degraded.This is due to the loop of calling
const_name
for all modules to find their names each time the paths are nested.This situation can easily occur in Rails applications and is worth addressing.
Solution
To suppress this loop, I modified
@modules
to beHash
to suppress the search cost.Comparison Code