core: Add Enumerator.produce #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
stdlib/Enumerator.produce
branch
2 times, most recently
from
f3acb2a
to
2ee4404
Compare
tk0miya
commented
Sep 11, 2023
| @@ -124,6 +124,43 @@ | |||
| class Enumerator[unchecked out Elem, out Return] < Object | |||
| include Enumerable[Elem] | |||
|
|
|||
| # <!-- | |||
There was a problem hiding this comment.
I copied this document from enumerator.c. Is that alright?
https://github.com/ruby/ruby/blob/master/enumerator.c#L3052-L3086
There was a problem hiding this comment.
I updated this comment by the result of CI (rake annotate?): https://github.com/ruby/rbs/actions/runs/6149970207/job/16686945264?pr=1516
core/enumerator.rbs
Outdated
| # PATTERN = %r{\d+|[-/+*]} | ||
| # Enumerator.produce { scanner.scan(PATTERN) }.slice_after { scanner.eos? }.first | ||
| # # => ["7", "+", "38", "/", "6"] | ||
| def self.produce: (?untyped initial) { (untyped prev) -> untyped } -> self |
There was a problem hiding this comment.
At first, I thought it would be better to use a type parameter for this method (ex. [T] (T initial) { (T prev) -> T } -> self[T, untyped]).
But developers can use the different types between initial and prev (the return type of the block). So it's difficult to give a better type to this method to me. Therefore, I used untyped for this.
tk0miya
force-pushed
the
stdlib/Enumerator.produce
branch
3 times, most recently
from
638717a
to
d862f19
Compare
tk0miya
commented
Sep 11, 2023
tk0miya
force-pushed
the
stdlib/Enumerator.produce
branch
from
d862f19
to
6f8affc
Compare
ParadoxV5
reviewed
Sep 13, 2023
soutaro
approved these changes
Sep 28, 2023
Add the signature for Enumerator.produce https://bugs.ruby-lang.org/issues/14781
Co-authored-by: Jimmy H <paradox.ver5@gmail.com>
soutaro
force-pushed
the
stdlib/Enumerator.produce
branch
from
ab4539a
to
3df06b7
Compare
Because the `#each` call never returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the signature for Enumerator.produce
https://bugs.ruby-lang.org/issues/14781