[Collection] Simple colorize collection text like Bundler #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
approved these changes
Oct 16, 2023
|
We may want to see |
|
Bundler is using also. I'll fix it. |
|
I have made a modification so that the color toggle can be switched with the environment variable |
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose adding color to the log outputs of the collection.
As the current logs generated by the collection aren't colored, there's a potential for misunderstanding whether a log is indicating an error or not.
It appears that the text is based on Bundler, so I've taken a cue from Bundler for the coloration. "Installing", "Updating", and the final "It's done!" are colored in green, while "Using" retains its current color. This makes the command's success more evident.