Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Abbrev to runtime dependency #1573

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ima1zumi
Copy link
Member

This PR adds Abbrev to runtime dependency to suppress the following Ruby 3.3's warning:

$ ruby -ve 'require "rbs/cli"'
ruby 3.3.0preview2 (2023-09-14 master e50fcca9a7) [x86_64-darwin21]
/Users/mi/.asdf/installs/ruby/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/rbs-3.2.2/lib/rbs/cli.rb:6: warning: abbrev which will be not part of the default gems since Ruby 3.4.0

ref: https://bugs.ruby-lang.org/issues/19351

This PR adds `Abbrev` to runtime dependency to suppress the following
Ruby 3.3's warning:

```console
$ ruby -ve 'require "rbs/cli"'
ruby 3.3.0preview2 (2023-09-14 master e50fcca9a7) [x86_64-darwin21]
/Users/mi/.asdf/installs/ruby/3.3.0-preview2/lib/ruby/gems/3.3.0+0/gems/rbs-3.2.2/lib/rbs/cli.rb:6: warning: abbrev which will be not part of the default gems since Ruby 3.4.0
```

ref: https://bugs.ruby-lang.org/issues/19351
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro added this pull request to the merge queue Oct 30, 2023
Merged via the queue into ruby:master with commit 20984fc Oct 30, 2023
23 checks passed
@soutaro soutaro added this to the RBS 3.3 milestone Oct 31, 2023
@soutaro soutaro added the Released PRs already included in the released version label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants