New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rbs diff] Resolve constants name #1601

Merged

soutaro merged 1 commit into ruby:master from ksss:diff-constant-resolver

Nov 9, 2023

Collaborator

ksss commented Nov 8, 2023

rbs diff command compares methods with their definitions resolved, but for constants, the comparison is a simple decl.

In this PR, constants are now compared as references from the specified type name by name resolution.


          Resolve constants name

4d2659a

soutaro approved these changes

View reviewed changes

Member

soutaro left a comment

👍

soutaro added this to the RBS 3.3 milestone

soutaro added this pull request to the merge queue

Merged via the queue into ruby:master with commit 41e3902

23 checks passed

ksss deleted the diff-constant-resolver branch

November 9, 2023 05:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet