Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using bundle command #1619

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Stop using bundle command #1619

merged 4 commits into from
Nov 21, 2023

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Nov 14, 2023 •
edited
Loading

Using bundle command makes running the test impossible on ruby CI.

This PR stops using #run_rbs and use #with_cli in cli_test.rb, except tests for rbs collection. It also renamed #run_rbs to #run_rbs_collection to avoid the confusion.

@soutaro soutaro added this to the RBS 3.3.x milestone Nov 14, 2023
@soutaro soutaro marked this pull request as ready for review November 14, 2023 19:02
@soutaro soutaro mentioned this pull request Nov 14, 2023
Merged
@soutaro soutaro added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit bd79c0b Nov 21, 2023
23 checks passed
@soutaro soutaro deleted the cli_test_no_bundler branch November 21, 2023 02:01
@soutaro soutaro added the Released PRs already included in the released version label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.3.x
Development

Successfully merging this pull request may close these issues.
1 participant
@soutaro