Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IO#gets type #1620

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix IO#gets type #1620

merged 1 commit into from
Nov 22, 2023

Conversation

kateinoigakukun
Copy link
Member

  • Can take a string as a nil separator
  • Can take limit integer as a first argument without a separator.
  • Can take an optional keyword argument chomp

sampersand
sampersand reviewed Nov 17, 2023
View reviewed changes
core/io.rbs Outdated Show resolved Hide resolved
@kateinoigakukun
Fix IO#gets type
c384900 
- Can take a string as a `nil` separator
- Can take limit integer as a first argument without a separator.
- Can take an optional keyword argument `chomp`
@soutaro soutaro added this to the RBS 3.4 milestone Nov 20, 2023
soutaro
soutaro approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro added this pull request to the merge queue Nov 22, 2023
Merged via the queue into ruby:master with commit d92e90e Nov 22, 2023
23 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/fix-io-gets branch November 22, 2023 02:46
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1620 from kateinoigakukun/katei/fix-io-gets"
45f5595 
This reverts commit d92e90e, reversing
changes made to a737401.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampersand sampersand sampersand left review comments

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@kateinoigakukun @soutaro @sampersand