Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBS::UnitTest modules #1660

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Add RBS::UnitTest modules #1660

merged 6 commits into from
Dec 5, 2023

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Dec 4, 2023 •
edited
Loading

We plan to add RBS type definitions in bundled gem repositories. This PR is to move the test helper features to RBS::UnitTest that ships within RBS gem.

  • Add RBS::UnitTest move some core modules
  • Update stdlib tests to use TestHelper module that is defined on the top of UnitTest modules
  • It also fixes OpenSSL type definition which is uncovered during stdlib test updates

@soutaro soutaro added this to the RBS 3.4 milestone Dec 4, 2023
@soutaro soutaro force-pushed the unit-test branch 2 times, most recently from 1f0f6c2 to 613b53e Compare December 4, 2023 06:29
@soutaro soutaro mentioned this pull request Dec 4, 2023
Merged
@soutaro soutaro added this pull request to the merge queue Dec 5, 2023
Merged via the queue into master with commit 2c5759d Dec 5, 2023
24 checks passed
@soutaro soutaro deleted the unit-test branch December 5, 2023 08:34
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1660 from ruby/unit-test"
e6b6d35 
This reverts commit 2c5759d, reversing
changes made to 735bb94.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
@ksss ksss mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.
1 participant
@soutaro