Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more details error message for UnresolvedOverloadingError #1688

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add more details error message for UnresolvedOverloadingError #1688

merged 1 commit into from
Dec 19, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 19, 2023

In RBS::Test, if an exception UnresolvedOverloadingError is reported, the following message is displayed, but we don't know the details of what did not match.

[Object#foo] UnresolvedOverloadingError: couldn't find a suitable overloading

I suggest that detailed information also be logged as follows.

W, [2023-12-19T13:35:17.268712 #21135]  WARN -- rbs: [Object#foo] UnresolvedOverloadingError method_type=`() -> ::String` details=["ArgumentError: expected method type () -> ::String", "ReturnTypeError: expected `::String` but returns `30`"], method_type=`(::Integer) -> ::String` details=["ReturnTypeError: expected `::String` but returns `30`"]
[Object#foo] UnresolvedOverloadingError: couldn't find a suitable overloading

I have made it so that the detailed information is output in the logger so that it can be turned off if not needed.

@soutaro soutaro added this to the RBS 3.4 milestone Dec 19, 2023
soutaro
soutaro approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@soutaro soutaro added this pull request to the merge queue Dec 19, 2023
Merged via the queue into ruby:master with commit 3a965cb Dec 19, 2023
23 checks passed
@ksss ksss deleted the UnresolvedOverloadingError-details branch December 19, 2023 09:09
soutaro added a commit that referenced this pull request Dec 20, 2023
@soutaro
Revert "Merge pull request #1688 from ksss/UnresolvedOverloadingError…
489cc9a 
…-details"

This reverts commit 3a965cb, reversing
changes made to 2fdb2e9.
@soutaro soutaro added the Released PRs already included in the released version label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
Released PRs already included in the released version
Milestone
RBS 3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro