Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timeout::ExitException #1803

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 16, 2024

Timeout::ExitException is an internal error.
However, it can appear in Ruby code.

Timeout.timeout(3) do
  begin
    long_run
  rescue StandardError => e
    logger.error(e)
    raise
  rescue Timeout::ExitException
    # skip logging
    raise
  end
end

Timeout::ExitException is an internal error.
However, it can appear in Ruby code.

```rb
Timeout.timeout(3) do
  begin
    long_run
  rescue StandardError => e
    logger.error(e)
    raise
  rescue Timeout::ExitException
    # skip logging
    raise
  end
end
```
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.5 milestone Apr 22, 2024
@soutaro soutaro added this pull request to the merge queue Apr 22, 2024
Merged via the queue into ruby:master with commit 9975229 Apr 22, 2024
17 checks passed
@ksss ksss deleted the timeout-exit-exception branch April 23, 2024 00:34
@soutaro soutaro added the Released PRs already included in the released version label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants