Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on the logger gem #1865

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

Earlopain
Copy link
Contributor

This is being bundled, starting in Ruby 3.4 it will warn: ruby/ruby@d7e558e

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soutaro soutaro enabled auto-merge June 6, 2024 05:40
This is being bundled, starting in Ruby 3.4 it will warn: ruby/ruby@d7e558e
auto-merge was automatically disabled June 6, 2024 06:47

Head branch was pushed to by a user without write access

@Earlopain
Copy link
Contributor Author

Fixed the conflic from that other PR

@soutaro soutaro added this to the RBS 3.5.x milestone Jun 7, 2024
@soutaro soutaro enabled auto-merge June 7, 2024 03:18
@soutaro soutaro added this pull request to the merge queue Jun 7, 2024
Merged via the queue into ruby:master with commit a2a38a2 Jun 7, 2024
18 of 19 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Jun 7, 2024
@Earlopain Earlopain deleted the add-logger-dep branch June 7, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants