Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use File.open instead of IO.sysopen #1912

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Use File.open instead of IO.sysopen #1912

merged 1 commit into from
Jul 11, 2024

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Jun 26, 2024

The default.close line sometimes raises an error:

https://github.com/ruby/actions/actions/runs/9667790393/job/26670618280#step:16:330

  ===============================================================================
  Error: test_grpowned?(FileTestSingletonTest): Errno::EBADF: Bad file descriptor
  test/stdlib/FileTest_test.rb:13:in 'IO#close'
  test/stdlib/FileTest_test.rb:13:in 'FileTestSingletonTest#with_path_io'
  test/stdlib/FileTest_test.rb:73:in 'FileTestSingletonTest#test_grpowned?'
  test/stdlib/io/Buffer_test.rb:67: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
  ===============================================================================

It's not very clear what is happening, but this PR is trying to use File instance instead of IO instance. Will run the Ruby CI with this patch and see what will happen.

@soutaro soutaro added this to the RBS 3.6 milestone Jun 26, 2024
@soutaro soutaro added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit 3d0f128 Jul 11, 2024
19 checks passed
@soutaro soutaro deleted the file-open branch July 11, 2024 01:43
@soutaro soutaro added the Released PRs already included in the released version label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

1 participant