Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date/datetime library types #367

Merged
merged 8 commits into from
Aug 25, 2020
Merged

Add date/datetime library types #367

merged 8 commits into from
Aug 25, 2020

Conversation

waka
Copy link
Contributor

@waka waka commented Aug 16, 2020

Add signatures of Date class and DateTime class.
This PR is based on the contributon guide.

soutaro
soutaro reviewed Aug 19, 2020
View reviewed changes
stdlib/date/date.rbs Outdated Show resolved Hide resolved
@waka waka requested a review from soutaro August 21, 2020 07:11
soutaro
soutaro approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro merged commit fa6d5fa into ruby:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waka @soutaro