Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keywords ending with ? or ! #417

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Allow keywords ending with ? or ! #417

merged 1 commit into from
Oct 16, 2020

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Oct 16, 2020

The problem is when a method accepts options ending with ? or !.

def foo(**opts) = opts
foo(a?: 1, b!: 2)        # OK

def bar(a?:, b!:) = ...         # Syntax error

So, this PR let keyword names in RBS end with ? and !.

@soutaro soutaro merged commit 5741322 into master Oct 16, 2020
@soutaro soutaro deleted the bang-keywords branch October 16, 2020 14:24
@marcandre
Copy link
Member

Note that keyword options currently accept just about anything, not just symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soutaro @marcandre