Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates the signature for the DBM #441

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Creates the signature for the DBM #441

merged 4 commits into from
Nov 3, 2020

Conversation

PanosCodes
Copy link
Contributor

Creates the signature for the DBM & tests

@PanosCodes PanosCodes mentioned this pull request Oct 28, 2020
Merged
@PanosCodes
Copy link
Contributor Author

The dbm gem is missing from the image 🤔

@soutaro
Copy link
Member

soutaro commented Nov 2, 2020

I got it. It's a problem...

@soutaro
Copy link
Member

soutaro commented Nov 3, 2020

Opened a pull request to set up dbm library: #460

Could you rebase this PR on the top of #460 so that we can confirm the fix works?

@soutaro soutaro self-assigned this Nov 3, 2020
@soutaro soutaro requested review from soutaro and removed request for soutaro November 3, 2020 03:42
@PanosCodes
Copy link
Contributor Author

Opened a pull request to set up dbm library: #460

Could you rebase this PR on the top of #460 so that we can confirm the fix works?

Done. The tests seem fine ✅, thank you for your work.

soutaro
soutaro approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soutaro soutaro merged commit d00cd5e into ruby:master Nov 3, 2020
@PanosCodes PanosCodes deleted the dbm branch November 3, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

@soutaro soutaro

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PanosCodes @soutaro