New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency definition to let tsort success #484

Merged

soutaro merged 1 commit into master from walker

Nov 23, 2020

Member

soutaro commented Nov 23, 2020

This is to make topological sort of core classes succeed.

Stop adding dependencies to ancestor arguments
Introduce *Node classes to distinguish instance and singleton

Thus, EnvironmentWalker runes over InstanceNode, SingletonNode, and TypeNameNode instances, not TypeName instances.


          Fix dependency definition to let tsort success

0889d70

soutaro merged commit ed176fe into master

soutaro deleted the walker branch

November 23, 2020 10:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet