Generate nested declarations #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate nested declarations while using `rbs prototype runtime` Signed-off-by: Sushanth Sathesh Rao <rao.sush004@gmail.com>
raosush
force-pushed
the
generate_nested_declarations_for_runtime_prototype
branch
from
dc6a25a
to
1222c3c
Compare
|
|
Great improvement! 👏 The code looks good generally. Update the test please, then I can finalize the PR/review. |
@soutaro Sir, the test has been updated and all checks are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rbs prototype runtimeProposal
Example
Fixes: #562
Signed-off-by: Sushanth Sathesh Rao rao.sush004@gmail.com