[openssl] Add RBS file for "openssl" #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoneyryderChuck
force-pushed
the
openssl
branch
from
2b140cb
to
f37a8b2
Compare
HoneyryderChuck
force-pushed
the
openssl
branch
from
f37a8b2
to
6345cbc
Compare
also fixed API for read/write_nonblock, specifically passing `exception: false`.
…ssing a timeout (it never returns nil)
HoneyryderChuck
force-pushed
the
openssl
branch
from
a746729
to
900a19d
Compare
HoneyryderChuck
force-pushed
the
openssl
branch
from
900a19d
to
df4854b
Compare
|
@soutaro sider checks fail in something I find debatable, i.e. block arguments shouldn't have the same expectation for boolish (at least in these cases, we know a bool will be yielded to block). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RBS signatures for the "openssl" package
Also adds the following:
IO.selectsignature for more accurate return type without timeout;SecureRandom.random_numbersignature for more accurate return type based on argument;exception: falseoption support forIO#read_nonblock/write_nonblock;