Add Ractor RBS #755
Merged
Add Ractor RBS #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think "because" is the most difficult spelling
pocke
commented
Aug 19, 2021
| end | ||
|
|
||
| def test_new | ||
| # TODO: it raises an error because the proc is not isolated |
There was a problem hiding this comment.
I guess we need to make assert_send_type Ractor safe to avoid this error, and I guess it is not easy. So I skipped the test case.
pocke
commented
Aug 19, 2021
| end | ||
|
|
||
| def test_select | ||
| r1 = Ractor.new { loop { Ractor.yield 42 } } |
There was a problem hiding this comment.
This test code leaks Ractor processes in some places. The leaks don't have a large impact because this test code is short-lived code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RBS for Ractor.