-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing Set and CGI signatures #761
Conversation
HoneyryderChuck
commented
Aug 23, 2021
•
edited
Loading
edited
- Set: set the same type of generic element as for arrays;
- CGI: added missing modules (Cookie, Util, Escape...)
6eda62e
to
22b9a27
Compare
955d324
to
c968690
Compare
@soutaro I see there's already an open PR for |
We don't have support for delegate classes. I'm not sure what is the best way... |
c968690
to
efab3ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HoneyryderChuck Could you update the type of json_create
s?
And we are waiting for #767 get merged, right?
efab3ac
to
44a452c
Compare
I'd say #767 is also dependent on #765 . Nevertheless, I'd be ok with merging it, as it's an acceptable workaround (and I just checked that However, it's a hack, as This type of more "dynamic-ish" typing will become more important to figure out as the stdlib signature set completes, as I think it's relevant for a few of them such as |
9e1a330
to
483f2ee
Compare
@soutaro I think this is ready to be merged. On the proposal above ☝️ , do you have some thoughts? |
@soutaro ping ☝️ |
483f2ee
to
84aa72e
Compare
* set the same type of generic element as for arrays;
84aa72e
to
581fc1b
Compare
@soutaro just rebased the latest changes, can you give it another try? |
@HoneyryderChuck Done! Fixed some issues myself and pushed to your repo. Thanks! 🙏 |