Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdlib sigs for io/console and io/console/size #783

Merged
merged 5 commits into from
Sep 18, 2021

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Sep 9, 2021

I've written rbs for the io/console and io/console/size library.

ref: https://github.com/ruby/io-console

@ksss
Copy link
Collaborator Author

ksss commented Sep 9, 2021

Oh, CI say Errno::ENOTTY...

@ksss
Copy link
Collaborator Author

ksss commented Sep 9, 2021

I used pty 🍔

stdlib/io-console/0/io-console.rbs Outdated Show resolved Hide resolved
stdlib/io-console/0/io-console.rbs Outdated Show resolved Hide resolved
stdlib/io-console/0/io-console.rbs Outdated Show resolved Hide resolved
stdlib/io-console/0/io-console.rbs Outdated Show resolved Hide resolved
stdlib/io-console/0/io-console.rbs Outdated Show resolved Hide resolved
test/stdlib/IO_console_test.rb Outdated Show resolved Hide resolved
@ksss
Copy link
Collaborator Author

ksss commented Sep 12, 2021

I resolved all conversation without #783 (comment) .

Should use untyped instead of top

Co-authored-by: Masataka Pocke Kuwabara <p.ck.t22@gmail.com>
@ksss
Copy link
Collaborator Author

ksss commented Sep 17, 2021

Resolved all conversation.

Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke merged commit c725af1 into ruby:master Sep 18, 2021
@ksss ksss deleted the io-console branch September 18, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants