Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Net::HTTP] Update Net::HTTPRequest signature #784

Merged
merged 3 commits into from
Sep 16, 2021
Merged

[Net::HTTP] Update Net::HTTPRequest signature #784

merged 3 commits into from
Sep 16, 2021

Conversation

raosush
Copy link
Contributor

@raosush raosush commented Sep 9, 2021

Description

  • Update signature of of Net::HTTPRequest to accept URI as a parameter
  • Update .gitignore file to ignore configuration files such as .rvmrc, .ruby-version, etc irrespective of sub-directory, since steep supports the aforementioned Ruby environments

pocke
pocke approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke merged commit a402b00 into ruby:master Sep 16, 2021
@raosush raosush deleted the update_http_request_sig branch September 16, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raosush @pocke