Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish argument type of #clone #811

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Polish argument type of #clone #811

merged 1 commit into from
Oct 23, 2021

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Oct 22, 2021

  • Should define Numeric#clone and shuold remove method on inherited class
  • Numeric#clone allow only true or nil by freeze option
  • Object#clone should allow nil on freeze option
  • Proc,Method,UnboundMethod and Binding #clone should not have freeze option

@ksss
Polish argument type of #clone
48bb280 
- Should define `Numeric#clone` and shuold remove method on inherited class
- `Numeric#clone` allow only `true` or `nil` by freeze option
- `Object#clone` should allow nil on freeze option
- `Proc`,`Method`,`UnboundMethod` and `Binding` `#clone` should not have freeze option
pocke
pocke approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I didn't know that clone is so difficult. 😵

@pocke pocke merged commit 884a8bc into ruby:master Oct 23, 2021
@ksss ksss deleted the clone branch October 23, 2021 12:57
@ksss ksss mentioned this pull request Oct 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @pocke