Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collection] Allow a relative path as git remote #839

Merged

Conversation

pocke
Copy link
Member

@pocke pocke commented Dec 9, 2021

rbs collection didn't allow a relative path as a git remote. For example:

# rbs_collection.yaml
sources:
  - name: ruby/gem_rbs_collection
    remote: ../../path/to/gem_rbs_collection/
    revision: main
    repo_dir: gems

I need to specify relative paths for test of ruby/gems_rbs_collection repo. In this repository, I'd like to refer to the repository itself for the test.

So this patch makes a relative path available as git remote.

@pocke pocke merged commit 537f3c6 into ruby:master Dec 12, 2021
@pocke pocke deleted the _collection__Allow_a_relative_path_as_git_remote branch December 12, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant