Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI sig improvements #864

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Conversation

HoneyryderChuck
Copy link
Contributor

Improving method defs which can receive a generic uri as arg.

Added sigs for new URI::HTTP methods added in v0.11.

@HoneyryderChuck
Copy link
Contributor Author

How can I fix the CI issue? it seems that I'd have to copy all prev version sigs, how can I just let them merge, or is the right fix to copy files?

@HoneyryderChuck
Copy link
Contributor Author

ping @soutaro

@soutaro
Copy link
Member

soutaro commented Feb 4, 2022

Hi @HoneyryderChuck,

Could you move to the updated RBS files to uri/0? We don't support providing RBS files for multiple versions, since URI is a default gem, gems which is always available even under bundler.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@HoneyryderChuck
Copy link
Contributor Author

@soutaro done

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@soutaro soutaro merged commit dafabf3 into ruby:master Feb 7, 2022
@HoneyryderChuck HoneyryderChuck deleted the fix-uri-param-in-uri branch February 7, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants