Fix FileTest signature and add tests #880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
Jan 31, 2022
test/stdlib/FileTest_test.rb
Outdated
| FileTest, :exist?, io_open | ||
| end | ||
|
|
||
| def test_exists? |
There was a problem hiding this comment.
exists? was removed in 3.0 (?). Deleting this test case would pass the test.
The `exists?` method was removed in Ruby 3.0, so there was no need to test it.
Merged
|
Closing this PR since #888 includes the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following method cannot receive IO instance as an argument, so I fixed it.
executable?executable_real?readable?readable_real?writable?writable_real?symlink?Also, I added tests.