Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value type for IO#wait_writable #943

Merged

Conversation

koic
Copy link
Contributor

@koic koic commented Mar 29, 2022

IO#wait_writable does not return bool unlike IO#wait_readable.
https://docs.ruby-lang.org/en/3.1/IO.html#method-i-wait_writable

@koic koic force-pushed the fix_return_value_type_for_io_wait_writable branch from a27a6f4 to 35bd6b6 Compare March 29, 2022 15:16
@soutaro
Copy link
Member

soutaro commented Mar 31, 2022

Let me confirm:

  1. This is the fix of method type, which is not changed since Ruby 3.1.1, and
  2. [ruby/io-wait] [DOC] Fix the return values #942 is the fix of document, which is changed since Ruby 3.1.1

RBS is based on the latest release of Ruby, 3.1.1 as of today. So, I will merge this, but won't #942.

Does it make sense?

core/io/wait.rbs Outdated Show resolved Hide resolved
@koic koic force-pushed the fix_return_value_type_for_io_wait_writable branch from 35bd6b6 to 76ebf2b Compare March 31, 2022 16:07
@koic
Copy link
Contributor Author

koic commented Mar 31, 2022

  1. [ruby/io-wait] [DOC] Fix the return values #942 is the fix of document, which is changed since Ruby 3.1.1

RBS is based on the latest release of Ruby, 3.1.1 as of today. So, I will merge this, but won't #942.

I don't have a strong opinion. OTOH, ruby/io-wait seems to be able to bundle update independently of the Ruby versions. So, I think it is possible to fix the document independently of Ruby 3.1.1.
ruby/io-wait@d0721e300a

Either way, that's just my point of view, and I'll leave the decision to the maintainers anyway. Thank you for your maintenance.

@soutaro
Copy link
Member

soutaro commented Apr 1, 2022

ruby/io-wait seems to be able to bundle update independently of the Ruby versions

Ah... it totally makes sense...
Yes, it's the problem of having gems in stdlib directory. So, let me leave it for now.

So, we will update the type now, but will update the doc later. Thanks again! 🙏

@soutaro soutaro merged commit 0393682 into ruby:master Apr 1, 2022
@koic koic deleted the fix_return_value_type_for_io_wait_writable branch April 1, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants