Fix (ArgumentError) invalid byte sequence in UTF-8 #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I exec
$ rb prototype rb
on the following file and found the problem.https://github.com/rails/rails/blob/b5630e232b95859c4171a285cd8f130e37d3c501/activesupport/lib/active_support/core_ext/digest/uuid.rb
I suggest using
String#ascii_only?
since the original Regexp(/\A[ -~]+\z/
) seemed to be determining if it was an ascii string only.As a side effect, strings like
""
and"foo\nbar"
, which were not previously converted as literals, are now recognized as literals.