Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken args after parsed decls from RBS::Prototype::RB #998

Merged
merged 1 commit into from
May 19, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented May 16, 2022

Decls created with RBS::Prototype::RB are in an unintended format and will cause errors when combined with RBS::Environment.

env = RBS::Environment.new
parser = RBS::Prototype::RB.new
parser.parse("H = []")
parser.decls.each do |decl|
  env << decl
end
env.resolve_type_names
/Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/types.rb:310:in `block in map_type_name': undefined method `map_type_name' for [#<RBS::Types::Bases::Any:0x0000000108d9a1a8 @location=nil>]:Array (NoMethodError)

          args: args.map {|type| type.map_type_name(&block) },
                                     ^^^^^^^^^^^^^^
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/types.rb:310:in `map'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/types.rb:310:in `map_type_name'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/environment.rb:477:in `absolute_type'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/environment.rb:353:in `resolve_declaration'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/environment.rb:239:in `block in resolve_type_names'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/environment.rb:235:in `each'
	from /Users/ksss/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/rbs-2.4.0/lib/rbs/environment.rb:235:in `resolve_type_names'
	from t.rb:9:in `<main>'
> parser.decls
=> [#<RBS::AST::Declarations::Constant:0x0000000108f46560
  @comment=nil,
  @location=nil,
  @name=#<RBS::TypeName:0x0000000108f46a38 @kind=:class, @name=:H, @namespace=#<RBS::Namespace:0x0000000108f46ab0 @absolute=false, @path=[]>>,
  @type=
   #<RBS::Types::ClassInstance:0x0000000108f46650
    @args=[[#<RBS::Types::Bases::Any:0x0000000108f467b8 @location=nil>]],
    @location=nil,
    @name=#<RBS::TypeName:0x000000010535bcf8 @kind=:class, @name=:Array, @namespace=#<RBS::Namespace:0x000000010535bd70 @absolute=true, @path=[]>>>>]

> RBS::Parser.parse_type("::Array[untyped]")
=>
#<RBS::Types::ClassInstance:0x0000000104d84578
 @args=[#<RBS::Types::Bases::Any:0x0000000104d84640 @location=#<RBS::Location:40400 buffer=a.rbs, start=1:8, pos=8...15, children= source='untyped'>>],
 @location=#<RBS::Location:40500 buffer=a.rbs, start=1:0, pos=0...16, children=name,?args source='::Array[untyped]'>,
 @name=#<RBS::TypeName:0x0000000104d847a8 @kind=:class, @name=:Array, @namespace=#<RBS::Namespace:0x0000000104d847f8 @absolute=true, @path=[]>>>

I think,

@args=[[#<RBS::Types::Bases::Any:0x0000000108f467b8 @location=nil>]]

should be

@args=[#<RBS::Types::Bases::Any:0x0000000108f467b8 @location=nil>]

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️ 👍 🎉

@soutaro soutaro merged commit 3b1e64e into ruby:master May 19, 2022
@ksss ksss deleted the args branch May 19, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants