Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move markup_reference.rb into misc directory #1125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okuramasafumi
Copy link
Contributor

Close #1123

@okuramasafumi
Copy link
Contributor Author

https://github.com/ruby/ruby/blob/master/tool/sync_default_gems.rb#L154
This line in ruby/ruby fails, and I don't know what to do... Could we simply delete that line?
I still believe this change worth, but if it's too difficult we need to abandon this PR.

@st0012
Copy link
Member

st0012 commented Jun 26, 2024

We need to update the line so it copies the file from the new destination instead.
I think we may limit disruption if we change things this way:

  1. We merge this PR, which will NOT be synced to ruby/ruby because the script will fail. But it should not affect other projects' syncing nor fail core's build
    • @hsbt is my understanding correct?
  2. Then we open a PR to ruby/ruby to update the script and manually sync the files

The purpose of this change is to leave `doc` directory for RDoc
so that `bundle exec rdoc` inside this repository will work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] bundle exec rdoc command should work for rdoc itself
2 participants