Add more invalid test cases for parsing entitly declaration

This patch will add the test cases to verify that it raises an exception properly when parsing malformed entity declaration.

test/parse/test_entity_declaration.rb

@@ -23,6 +23,158 @@ def parse(internal_subset)
     end
 
     public
+
+    class TestGarbagedValue < self
+      def test_garbaged_after_entity_definition
+        exception = assert_raise(REXML::ParseException) do
+          REXML::Document.new('<!DOCTYPE root [<!ENTITY "foo" xxx > ]>')
+        end
+        assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 39
+Last 80 unconsumed characters:
+ \"foo\" xxx > ]>
+        DETAIL
+      end
+
+      class TestSystem < self
+        def test_garbaged_between_system_and_literal
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo SYSTEM xxx "bar" > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 50
+Last 80 unconsumed characters:
+ foo SYSTEM xxx \"bar\" > ]>
+          DETAIL
+        end
+
+        def test_garbaged_after_literal
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo SYSTEM "bar" xxx > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 50
+Last 80 unconsumed characters:
+ foo SYSTEM \"bar\" xxx > ]>
+          DETAIL
+        end
+
+        def test_garbaged_between_literal_and_ndata_declaration
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo SYSTEM "bar" xxx NDATA gif > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 60
+Last 80 unconsumed characters:
+ foo SYSTEM \"bar\" xxx NDATA gif > ]>
+          DETAIL
+        end
+
+        def test_garbaged_after_ndata_declaration
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo SYSTEM "bar" NDATA gif xxx > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 60
+Last 80 unconsumed characters:
+ foo SYSTEM \"bar\" NDATA gif xxx > ]>
+          DETAIL
+        end
+      end
+
+      class TestPublic < self
+        def test_garbaged_between_public_and_first_literal
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC xxx "bar" "baz" > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 56
+Last 80 unconsumed characters:
+ foo PUBLIC xxx \"bar\" \"baz\" > ]>
+          DETAIL
+        end
+
+        def test_garbaged_between_literals
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC "bar" xxx "baz" > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 56
+Last 80 unconsumed characters:
+ foo PUBLIC \"bar\" xxx \"baz\" > ]>
+          DETAIL
+        end
+
+        def test_garbaged_after_literals
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC "bar" "baz" xxx > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 56
+Last 80 unconsumed characters:
+ foo PUBLIC \"bar\" \"baz\" xxx > ]>
+          DETAIL
+        end
+
+        def test_garbaged_between_literal_and_ndata_declaration
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC "bar" "baz" xxx NDATA gif > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 66
+Last 80 unconsumed characters:
+ foo PUBLIC \"bar\" \"baz\" xxx NDATA gif > ]>
+          DETAIL
+        end
+
+        def test_garbaged_after_ndata_declaration
+          exception = assert_raise(REXML::ParseException) do
+            REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC "bar" "baz" NDATA gif xxx > ]>')
+          end
+          assert_equal(<<-DETAIL.chomp, exception.to_s)
+Malformed entity declaration
+Line: 1
+Position: 66
+Last 80 unconsumed characters:
+ foo PUBLIC \"bar\" \"baz\" NDATA gif xxx > ]>
+          DETAIL
+        end
+      end
+    end
+
+    class TestCharacterCode < self
+      def test_pubid_literal
+        exception = assert_raise(REXML::ParseException) do
+          REXML::Document.new('<!DOCTYPE root [<!ENTITY foo PUBLIC "あいう" "bar" > ]>')
+        end
+        assert_equal(<<-DETAIL.chomp, exception.to_s.force_encoding('utf-8'))
+Malformed entity declaration
+Line: 1
+Position: 58
+Last 80 unconsumed characters:
+ foo PUBLIC \"あいう\" \"bar\" > ]>
+        DETAIL
+      end
+    end
+
     def test_empty
       exception = assert_raise(REXML::ParseException) do
         parse(<<-INTERNAL_SUBSET)