Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for Text.check #166

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix test for Text.check #166

merged 1 commit into from
Jul 11, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Jul 11, 2024

This patch will fix incorrect string in a case where unicode characters.
Because of the use of single quotes, it was simply an ASCII string.

@kou
Copy link
Member

kou commented Jul 11, 2024

Could you always use " to avoid similar mistakes?

This patch will fix incorrect string in a case where unicode characters.
Because of the use of single quotes, it was simply an ASCII string.
@Watson1978
Copy link
Contributor Author

Replaced all ' to " in test_text_check.rb

@kou kou merged commit 87f7cd0 into ruby:master Jul 11, 2024
61 checks passed
@kou
Copy link
Member

kou commented Jul 11, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants