Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeError in REXML::Parsers::BaseParser for valid feeds #199

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Fix RuntimeError in REXML::Parsers::BaseParser for valid feeds #199

merged 6 commits into from
Aug 17, 2024

Commits on Aug 14, 2024

  1. Fix RuntimeError for valid feeds 

    * Change `#entity` to not match against default entities

Close ruby#198
    @vikiv480
    vikiv480 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    981b424 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. PR feedback 

    * Explicitly set `value` to `nil`
* Remove unnecessary conditional

Co-Authored-By: Sutou Kouhei <kou@clear-code.com>
    @vikiv480 @kou
    vikiv480 and kou committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b5da207 View commit details
    Browse the repository at this point in the history

  2. Add tests when default entities only 

    Adds tests for SAX parser, Pull parser and Stream parser when the source contains only default entities
    @vikiv480
    vikiv480 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6555c27 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Improve readability for #entity 

    * Early return if there is no `entities`
* Early return if there is no match for `reference` in `entities`

Co-Authored-By: NAITOH Jun <naitoh@gmail.com>
    @vikiv480 @naitoh
    vikiv480 and naitoh committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    60632a5 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary StringIO.new 

    * Remove unnecessary `StringIO.new`

Co-Authored-By: NAITOH Jun <naitoh@gmail.com>
    @vikiv480 @naitoh
    vikiv480 and naitoh committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b7e9378 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Remove a needless empty line

    @kou
    kou committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    cd05526 View commit details
    Browse the repository at this point in the history