Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strscan dependency declaration from gemspec #204

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Bo98
Copy link
Contributor

@Bo98 Bo98 commented Sep 4, 2024

See discussion in #140. strscan is a part of the Ruby standard library in all versions of Ruby supported by REXML.

Fixes #140.

@Bo98 Bo98 mentioned this pull request Sep 4, 2024
@kou kou merged commit ad02f99 into ruby:master Sep 4, 2024
60 of 61 checks passed
@kou
Copy link
Member

kou commented Sep 4, 2024

Thanks.

The Document CI failure is unrelated.

@Bo98 Bo98 deleted the strscan-remove branch September 4, 2024 03:04
@hachi8833
Copy link

Thank you for the fix!
Hope you released the fixed version of rexml soon.


I got the following error on GitHub CI's bundle install, which seems to come from this issue.

Downloading rexml-3.3.6 revealed dependencies not in the API or the lockfile
(strscan (>= 0)).
Running `bundle update rexml` should fix the problem.
Error: The process '/opt/hostedtoolcache/Ruby/3.3.5/x64/bin/bundle' failed with exit code 34

I did a workaround by adding gem 'rexml', github: "ruby/rexml" to Gemfile for now.
I expect this workaround will be unnecessary when the fixed version of rexml is released.

@kou
Copy link
Member

kou commented Sep 4, 2024

We need to fix the CI failure before we release a new version.
Could you try it?

@Bo98
Copy link
Contributor Author

Bo98 commented Sep 4, 2024

Unfortunately, it's a Ruby bug it seems: https://bugs.ruby-lang.org/issues/20713.

We can workaround it though I think: #205

@kou
Copy link
Member

kou commented Sep 4, 2024

Thanks for taking a look at this.
I thought that nobody is working on this. So I've done by myself...

@kou
Copy link
Member

kou commented Sep 4, 2024

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

REXML is no longer pure ruby
3 participants