fix: always use a sql safe table name in failed events manager #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandumlg
approved these changes
Nov 7, 2022
Codecov ReportBase: 45.45% // Head: 45.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
- Coverage 45.45% 45.44% -0.02%
==========================================
Files 287 287
Lines 47785 47790 +5
==========================================
- Hits 21721 21716 -5
- Misses 24689 24696 +7
- Partials 1375 1378 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
BonapartePC
approved these changes
Nov 7, 2022
pChondros
approved these changes
Nov 7, 2022
saurav-malani
approved these changes
Nov 7, 2022
This was referenced Nov 7, 2022
Closed
Merged
lvrach
reviewed
Nov 10, 2022
| @@ -188,3 +188,7 @@ func CleanFailedRecordsTableProcess(ctx context.Context) { | |||
| func (fem *FailedEventsManagerT) GetDBHandle() *sql.DB { | |||
| return fem.dbHandle | |||
| } | |||
|
|
|||
| func getSqlSafeTablename(taskRunID string) string { | |||
| return `"` + strings.ReplaceAll(fmt.Sprintf(`%s_%s`, failedKeysTablePrefix, taskRunID), `"`, `""`) + `"` | |||
There was a problem hiding this comment.
pq.QuoteIdentifier can be used as well.
This was referenced Nov 11, 2022
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted a common function for escaping the table name and including a scenario missed by #2663
Security