Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle trade desk null, undefined fields #3661

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Aug 14, 2024

What are the changes introduced in this PR?

  • Existing code is breaking the transformer <> server contract when field is null, undefined for any job.
  • With this change we are aborting the whole job, If any field is null, undefined or empty, and respecting the transformer <> server contract.

What is the related Linear task?

Resolves INT-2538

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@Gauravudia Gauravudia self-assigned this Aug 14, 2024
@Gauravudia Gauravudia marked this pull request as ready for review August 14, 2024 11:30
@Gauravudia Gauravudia requested review from a team and sivashanmukh as code owners August 14, 2024 11:30
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (ec0bffe) to head (cefb3c1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3661   +/-   ##
========================================
  Coverage    88.55%   88.55%           
========================================
  Files          585      585           
  Lines        31910    31914    +4     
  Branches      7613     7613           
========================================
+ Hits         28258    28262    +4     
  Misses        3359     3359           
  Partials       293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 26, 2024

@Gauravudia Gauravudia merged commit 2d8b315 into develop Aug 26, 2024
24 of 26 checks passed
@Gauravudia Gauravudia deleted the fix.tradeDesk branch August 26, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants