fix: login using docker creds on the node to allow to pull the desired image #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3682/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3682 +/- ##
========================================
Coverage 88.55% 88.55%
========================================
Files 585 585
Lines 31910 31914 +4
Branches 7613 7615 +2
========================================
+ Hits 28258 28262 +4
+ Misses 3359 3329 -30
- Partials 293 323 +30 ☔ View full report in Codecov by Sentry. |
Jayachand
previously approved these changes
Aug 26, 2024
utsabc
previously approved these changes
Aug 26, 2024
abhimanyubabbar
dismissed stale reviews from utsabc, sivashanmukh, and Jayachand
via
1fd195d
|
utsabc
approved these changes
Aug 26, 2024
Jayachand
approved these changes
Aug 26, 2024
sivashanmukh
approved these changes
Aug 26, 2024
kanishkkatara
pushed a commit
that referenced
this pull request
Aug 27, 2024
…d image (#3682) * fix: login using docker creds on the node to allow to pull the desired image * fix: add steps to create regcred secret and then patch deployment with it * chore: fix the github action * chore: patch the service account in openfaas-fn ns to allow for pulling openfaas flask base images * chore: minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We broke the UT tests when we made our images private. This test fixes the docker hub authorization issue but creating a regcred secret through docker credentials to be used for patching deployments and service accounts
What is the related Linear task?
Fixes DAT-1487
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.