Add PHPStan

[franmomu]

This PR tries to add PHPStan at level 3 that doesn't require many changes and I think it's a good start. The issues ignored are mostly about accessing dynamic fields (from Document) and through Facade.

[ruflin]

I'm definitively in support of adding these kind of automation to improve the code quality. Don't really have any experience with PHPStan but maybe @deguif or @thePanz can have a more detailed look?

[thePanz]

Nice addition, gracias @franmomu!
There are a couple of exceptions, that would need a clarification, but LGTM!
This is a good first step to have Phpstan, I still fear that increasing to higher levels will be quite hard due to the dynamic fields and the mixed parameters we have for some properties

[franmomu]

Nice addition, gracias @franmomu! There are a couple of exceptions, that would need a clarification, but LGTM! This is a good first step to have Phpstan, I still fear that increasing to higher levels will be quite hard due to the dynamic fields and the mixed parameters we have for some properties

de nada! 😉 Yeah, higher levels will need more work, we'll see when we get there

[deguif]

Related issue: #1943

[ruflin]

@thePanz Feel free to merge it in if you think it is ready.

@franmomu It would be nice to add an entry in the changelog around this addition even though it is not affecting the lib itself.

[thePanz]

@deguif I lost track of your PR, sorry for that.
Should we merge this one, and rebase yours? wdyt?

[deguif]

@thePanz I didn't open a PR ;)
I just did some small PRs to fix some PHPStan warnings a while ago.
Yes, we can merge this one.

[thePanz]

And merged @franmomu (\cc @ruflin @deguif )