Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixlsx Fork - Patch issue with nil/empty cells unable to be styled #1

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

GorillaCoffee
Copy link

@GorillaCoffee GorillaCoffee commented Jul 3, 2024

Changes

What issue?

  • Passing nil as the contents of a cell specs causes the cell to render unstyled and with no formatting ☹️
  • Passing "" is a solution, but raises an error if the cell uses formatting (notably datetime)
  • There seems to be an ongoing PR, but it only fixes the issue for DateTime formatting

Why a fork?

While being aware that forks are generally not desired...

  • This repo is being maintained somewhat slowly 🐌 It might take a while before a PR is accepted
  • This repo is very mature. If we hit any conflicts, we can assume they won't be very major
  • My experience with the repo isn't enough to feel confident doing a PR to its public repo
  • matter of tradeoffs 🤷‍♂️

Example

Before ❌ 👎
image

After ✅ 😁
image

@marcofiset marcofiset merged commit cd55eb1 into master Jul 4, 2024
@marcofiset marcofiset deleted the rum-patch branch July 4, 2024 18:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants