Split up /call and /logs.
#1152
Open
+261
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/servers/http/http_client.py
Did you find this useful? React with a 👍 or 👎 |
This was referenced Aug 14, 2024
jlewitt1
reviewed
Aug 15, 2024
runhouse/servers/http/http_server.py
Outdated
| @@ -68,6 +71,9 @@ | |||
|
|
|||
| app = FastAPI(docs_url=None, redoc_url=None) | |||
|
|
|||
| # TODO: Better way to store this than a global here? | |||
| running_futures: Dict[str, Future] = {} | |||
There was a problem hiding this comment.
not sure if it's really any better, but could store it in the FastAPI app state, since this is only useful for the life of the server anyway right?
jlewitt1
reviewed
Aug 15, 2024
| @@ -461,6 +462,32 @@ async def get_call( | |||
| serialization=serialization, | |||
| ) | |||
|
|
|||
| # `/logs` POST endpoint that takes in request and LogParams | |||
| @staticmethod | |||
| @app.get("/logs/{run_name}/{serialization}") | |||
There was a problem hiding this comment.
what serialization options are relevant for logs?
There was a problem hiding this comment.
in the event of exception we still need to serialize with the expected type
jlewitt1
reviewed
Aug 15, 2024
runhouse/servers/http/http_server.py
Outdated
| @@ -68,6 +71,9 @@ | |||
|
|
|||
| app = FastAPI(docs_url=None, redoc_url=None) | |||
|
|
|||
| # TODO: Better way to store this than a global here? | |||
| running_futures: Dict[str, Future] = {} | |||
There was a problem hiding this comment.
small nit - isn't this technically storing a Task object
jlewitt1
reviewed
Aug 15, 2024
| result = handle_response( | ||
| resp, output_type, error_str, log_formatter=self.log_formatter | ||
| with ThreadPoolExecutor() as executor: | ||
| # Run logs request in separate thread. Can start it before because it'll wait 5 seconds for the |
There was a problem hiding this comment.
maybe i missed this but where are is the delay for the calls request to begin?
There was a problem hiding this comment.
There's no delay for that... in the /logs endpoint server side, there's a delay where it waits for the call to start.
rohinb2
force-pushed
the
08-14-Make_thread_coroutine_more_generally_usable
branch
from
fe8cb72
to
9bee76b
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
7cb3b41
to
6d77b0e
Compare
rohinb2
force-pushed
the
08-14-Make_thread_coroutine_more_generally_usable
branch
from
9bee76b
to
6b66f66
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
6d77b0e
to
8a9a1aa
Compare
rohinb2
force-pushed
the
08-14-Make_thread_coroutine_more_generally_usable
branch
from
6b66f66
to
04232f8
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
8a9a1aa
to
d0decb7
Compare
rohinb2
force-pushed
the
08-14-Make_thread_coroutine_more_generally_usable
branch
from
04232f8
to
1a4b9ca
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
d0decb7
to
3e892d6
Compare
rohinb2
changed the base branch from
08-14-Make_thread_coroutine_more_generally_usable
to
graphite-base/1152
rohinb2
force-pushed
the
graphite-base/1152
branch
from
1a4b9ca
to
cde74ae
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
3e892d6
to
47fa18b
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
9 times, most recently
from
f2d9f49
to
80cb59e
Compare
This was referenced Aug 25, 2024
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
80cb59e
to
ec4ac45
Compare
rohinb2
force-pushed
the
08-14-Split_up_/call_and_/logs_
branch
from
ec4ac45
to
d43439a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.